diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2021-11-22 19:52:45 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-11-23 12:09:09 +0000 |
| commit | dd06a0c6b6f64f6610c0bb8f7651df3ebfb0f990 (patch) | |
| tree | 63b6d8f0a12f9a024f74e8b2513243e1c64a975f /drivers/spi | |
| parent | 350de7ce26caba5c7ec0dd4ef1802c9a50a5d85d (diff) | |
| download | lwn-dd06a0c6b6f64f6610c0bb8f7651df3ebfb0f990.tar.gz lwn-dd06a0c6b6f64f6610c0bb8f7651df3ebfb0f990.zip | |
spi: spidev: Use SPI_MODE_USER_MASK instead of casting
Currently the 16-bit mode is what being used in user space.
However assuming that is not fully correct. Instead we should
use the respective mask, i.e. SPI_MODE_USER_MASK, which
precisely defines what bits are available for user space apps.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211122175245.84691-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spidev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 1bd73e322b7b..968dab2f5e3d 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -415,7 +415,7 @@ spidev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) tmp |= SPI_CS_HIGH; tmp |= spi->mode & ~SPI_MODE_MASK; - spi->mode = (u16)tmp; + spi->mode = tmp & SPI_MODE_USER_MASK; retval = spi_setup(spi); if (retval < 0) spi->mode = save; |