diff options
| author | Mingwei Zheng <zmw12306@gmail.com> | 2024-12-06 20:52:06 -0500 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-12-09 13:14:35 +0000 |
| commit | 8332e667099712e05ec87ba2058af394b51ebdc9 (patch) | |
| tree | 080ae71f80a70f19f08eb9e88724b45ee3d54cd4 /drivers/spi/spi-zynq-qspi.c | |
| parent | e5fca61fdfcdd7d3cc43c0b4c3b959d4f2b06666 (diff) | |
| download | lwn-8332e667099712e05ec87ba2058af394b51ebdc9.tar.gz lwn-8332e667099712e05ec87ba2058af394b51ebdc9.zip | |
spi: zynq-qspi: Add check for clk_enable()
Add check for the return value of clk_enable() to catch the potential
error.
Fixes: c618a90dcaf3 ("spi: zynq-qspi: Drop GPIO header")
Signed-off-by: Mingwei Zheng <zmw12306@gmail.com>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Link: https://patch.msgid.link/20241207015206.3689364-1-zmw12306@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-zynq-qspi.c')
| -rw-r--r-- | drivers/spi/spi-zynq-qspi.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index dee9c339a35e..5caf0abf3763 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -379,12 +379,21 @@ static int zynq_qspi_setup_op(struct spi_device *spi) { struct spi_controller *ctlr = spi->controller; struct zynq_qspi *qspi = spi_controller_get_devdata(ctlr); + int ret; if (ctlr->busy) return -EBUSY; - clk_enable(qspi->refclk); - clk_enable(qspi->pclk); + ret = clk_enable(qspi->refclk); + if (ret) + return ret; + + ret = clk_enable(qspi->pclk); + if (ret) { + clk_disable(qspi->refclk); + return ret; + } + zynq_qspi_write(qspi, ZYNQ_QSPI_ENABLE_OFFSET, ZYNQ_QSPI_ENABLE_ENABLE_MASK); |