diff options
| author | Rasmus Villemoes <rasmus.villemoes@prevas.dk> | 2021-01-30 15:35:45 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-02-01 13:19:00 +0000 |
| commit | 9d2aa6dbf87af89c13cac2d1b4cccad83fb14a7e (patch) | |
| tree | fb1021d3eb0913e050cb28a311c380f7cd972482 /drivers/spi/spi-fsl-spi.c | |
| parent | 396cf2a46adddbf51373e16225c1d25254310046 (diff) | |
| download | lwn-9d2aa6dbf87af89c13cac2d1b4cccad83fb14a7e.tar.gz lwn-9d2aa6dbf87af89c13cac2d1b4cccad83fb14a7e.zip | |
spi: fsl: invert spisel_boot signal on MPC8309
Commit 7a2da5d7960a ("spi: fsl: Fix driver breakage when SPI_CS_HIGH
is not set in spi->mode") broke our MPC8309 board by effectively
inverting the boolean value passed to fsl_spi_cs_control. The
SPISEL_BOOT signal is used as chipselect, but it's not a gpio, so
we cannot rely on gpiolib handling the polarity.
Adapt to the new world order by inverting the logic here. This does
assume that the slave sitting at the SPISEL_BOOT is active low, but
should that ever turn out not to be the case, one can create a stub
gpiochip driver controlling a single gpio (or rather, a single "spo",
special-purpose output).
Fixes: 7a2da5d7960a ("spi: fsl: Fix driver breakage when SPI_CS_HIGH is not set in spi->mode")
Cc: stable@vger.kernel.org
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Link: https://lore.kernel.org/r/20210130143545.505613-1-rasmus.villemoes@prevas.dk
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-fsl-spi.c')
| -rw-r--r-- | drivers/spi/spi-fsl-spi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index 6d8e0a05a535..e4a8d203f940 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -695,7 +695,7 @@ static void fsl_spi_cs_control(struct spi_device *spi, bool on) if (WARN_ON_ONCE(!pinfo->immr_spi_cs)) return; - iowrite32be(on ? SPI_BOOT_SEL_BIT : 0, pinfo->immr_spi_cs); + iowrite32be(on ? 0 : SPI_BOOT_SEL_BIT, pinfo->immr_spi_cs); } } |