summaryrefslogtreecommitdiff
path: root/drivers/rtc/rtc-x1205.c
diff options
context:
space:
mode:
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>2022-01-26 09:17:15 +0800
committerVinod Koul <vkoul@kernel.org>2022-02-11 12:17:55 +0530
commit63fadaa2c7190ad6fc546a8b95e044bd75422dec (patch)
tree8dc6e0a79bbe2fa9b484e942b77f8530a190ca19 /drivers/rtc/rtc-x1205.c
parentf3016b891c8c6f11434eab5b92a0bbc21c1dfb6e (diff)
downloadlwn-63fadaa2c7190ad6fc546a8b95e044bd75422dec.tar.gz
lwn-63fadaa2c7190ad6fc546a8b95e044bd75422dec.zip
soundwire: stream: make enable/disable/deprepare idempotent
The stream management currently flags an 'inconsistent state' error when a change is requested multiple times. This was added on purpose to identify programming mistakes. In hindsight, there was no real reason to fail if the logic at the ASoC-DPCM level invokes the same callback multiple times. It's perfectly acceptable to just return and not flag an error when there is nothing to do. The main concern with the state management is to trap errors such as trying to enable a stream that was not prepared first. This patch suggests allowing the stream functions to be idempotent, i.e. they can be called multiple times. Note that the prepare case was already handling multiple calls, this was added in commit c32464c9393d ("soundwire: stream: only prepare stream when it is configured.") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Link: https://lore.kernel.org/r/20220126011715.28204-20-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/rtc/rtc-x1205.c')
0 files changed, 0 insertions, 0 deletions