diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-02-21 00:20:43 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-03-01 10:49:40 +0100 |
| commit | bff11e3aa9ccfce1a66ef05871d01c1da533f896 (patch) | |
| tree | 0b63ea90eeb19143e52a910f06026c8214d9f5a6 /drivers/rtc/rtc-rs5c348.c | |
| parent | 812318a094d0715194d9f686b22ee67e7dc59d93 (diff) | |
| download | lwn-bff11e3aa9ccfce1a66ef05871d01c1da533f896.tar.gz lwn-bff11e3aa9ccfce1a66ef05871d01c1da533f896.zip | |
rtc: rs5c348: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc/rtc-rs5c348.c')
| -rw-r--r-- | drivers/rtc/rtc-rs5c348.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c index 9a306983aaba..f2de8b17e7e3 100644 --- a/drivers/rtc/rtc-rs5c348.c +++ b/drivers/rtc/rtc-rs5c348.c @@ -135,11 +135,6 @@ rs5c348_rtc_read_time(struct device *dev, struct rtc_time *tm) tm->tm_year = bcd2bin(rxbuf[RS5C348_REG_YEAR]) + ((rxbuf[RS5C348_REG_MONTH] & RS5C348_BIT_Y2K) ? 100 : 0); - if (rtc_valid_tm(tm) < 0) { - dev_err(&spi->dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); - } - return 0; } |