diff options
| author | Bjorn Andersson <quic_bjorande@quicinc.com> | 2023-04-18 09:30:17 -0700 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2023-04-19 12:43:19 -0700 |
| commit | 7a68f9fa97357a0f2073c9c31ed4101da4fce93e (patch) | |
| tree | 5739c2b13b0c7b9b6439531327060f053d96fa70 /drivers/rpmsg/qcom_glink_native.c | |
| parent | c05dfce0b89e3b58043805b6f4bdf30e3561d867 (diff) | |
| download | lwn-7a68f9fa97357a0f2073c9c31ed4101da4fce93e.tar.gz lwn-7a68f9fa97357a0f2073c9c31ed4101da4fce93e.zip | |
rpmsg: glink: Propagate TX failures in intentless mode as well
As support for splitting transmission over several messages using
TX_DATA_CONT was introduced it does not immediately return the return
value of qcom_glink_tx().
The result is that in the intentless case (i.e. intent == NULL), the
code will continue to send all additional chunks. This is wasteful, and
it's possible that the send operation could incorrectly indicate
success, if the last chunk fits in the TX fifo.
Fix the condition.
Fixes: 8956927faed3 ("rpmsg: glink: Add TX_DATA_CONT command while sending")
Reviewed-by: Chris Lew <quic_clew@quicinc.com>
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230418163018.785524-2-quic_bjorande@quicinc.com
Diffstat (limited to 'drivers/rpmsg/qcom_glink_native.c')
| -rw-r--r-- | drivers/rpmsg/qcom_glink_native.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 196ca7d8df7c..916c0dbe4213 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -1371,8 +1371,9 @@ static int __qcom_glink_send(struct glink_channel *channel, ret = qcom_glink_tx(glink, &req, sizeof(req), data, chunk_size, wait); /* Mark intent available if we failed */ - if (ret && intent) { - intent->in_use = false; + if (ret) { + if (intent) + intent->in_use = false; return ret; } @@ -1393,8 +1394,9 @@ static int __qcom_glink_send(struct glink_channel *channel, chunk_size, wait); /* Mark intent available if we failed */ - if (ret && intent) { - intent->in_use = false; + if (ret) { + if (intent) + intent->in_use = false; break; } } |