diff options
| author | Bjorn Andersson <bjorn.andersson@linaro.org> | 2017-02-15 14:00:41 -0800 |
|---|---|---|
| committer | Bjorn Andersson <bjorn.andersson@linaro.org> | 2017-02-22 02:07:13 -0800 |
| commit | 01625cc5e65f420dbea57f7de6b9552a0f807a84 (patch) | |
| tree | db133dd5046653862d136263a1238a185278d84a /drivers/remoteproc/qcom_q6v5_pil.c | |
| parent | 231c8dfd1a9ff530869e1327ba4168dbe592f3f9 (diff) | |
| download | lwn-01625cc5e65f420dbea57f7de6b9552a0f807a84.tar.gz lwn-01625cc5e65f420dbea57f7de6b9552a0f807a84.zip | |
remoteproc: qcom: mdt_loader: Use signed type for offset
In the transition from using rproc_da_to_va(), the type of the load
offset became unsigned. This causes the subsequent check to let negative
values less than p_memsz + mem_size through and we write outside of the
buffer.
Change the type back to a signed value to catch this.
Fixes: 7f0dd07a9b29 ("remoteproc: qcom: mdt_loader: Refactor MDT loader")
Fixes: e7fd25226295 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Acked-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Diffstat (limited to 'drivers/remoteproc/qcom_q6v5_pil.c')
| -rw-r--r-- | drivers/remoteproc/qcom_q6v5_pil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 26446eb08bd8..8fd697a3cf8f 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -502,7 +502,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) phys_addr_t max_addr = 0; bool relocate = false; char seg_name[10]; - size_t offset; + ssize_t offset; size_t size; void *ptr; int ret; |