diff options
| author | Tony Luck <tony.luck@intel.com> | 2022-10-18 09:59:00 -0700 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2022-10-31 18:55:18 +0100 |
| commit | 50865c14f34edbd03f8113147fac069b39f4e390 (patch) | |
| tree | d0d9239b0a39a40ac6afdfa95b9abbcb02674e26 /drivers/ras | |
| parent | a51cbd0d86d3fa9ecc6ddf186dd1cb66a4fefa87 (diff) | |
| download | lwn-50865c14f34edbd03f8113147fac069b39f4e390.tar.gz lwn-50865c14f34edbd03f8113147fac069b39f4e390.zip | |
RAS: Fix return value from show_trace()
Documentation/filesystems/seq_file.rst describes the possible return
values from a "show()" function used by single_open().
show_trace() returns the value of "trace_count". This could be
interpreted as "SEQ_SKIP", or just confuse the calling function.
Change to just return "0" to avoid confusing anyone reading this code
and possibly using as a template. Reading "daemon_active" was never
an intended use case.
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20221018165900.109029-1-tony.luck@intel.com
Diffstat (limited to 'drivers/ras')
| -rw-r--r-- | drivers/ras/debugfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c index 0d4f985afbf3..f0a6391b1146 100644 --- a/drivers/ras/debugfs.c +++ b/drivers/ras/debugfs.c @@ -15,7 +15,7 @@ EXPORT_SYMBOL_GPL(ras_userspace_consumers); static int trace_show(struct seq_file *m, void *v) { - return atomic_read(&trace_count); + return 0; } static int trace_open(struct inode *inode, struct file *file) |