diff options
| author | Vadim Pasternak <vadimp@nvidia.com> | 2022-08-23 23:19:34 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-09-01 14:22:48 +0200 |
| commit | 17c2bd6bea4c32fe691c1f9ebcc20fd48d77454a (patch) | |
| tree | 20da3d4d5209388781aa6a261b8993a7695e0fa7 /drivers/platform | |
| parent | c3b82d26bc85f5fc2fef5ec8cce17c89633a55a8 (diff) | |
| download | lwn-17c2bd6bea4c32fe691c1f9ebcc20fd48d77454a.tar.gz lwn-17c2bd6bea4c32fe691c1f9ebcc20fd48d77454a.zip | |
platform/mellanox: mlxreg-lc: Fix coverity warning
Fix smatch warning:
drivers/platform/mellanox/mlxreg-lc.c:866 mlxreg_lc_probe() warn: passing zero to 'PTR_ERR'
by removing 'err = PTR_ERR(regmap)'.
Fixes: b4b830a34d80 ("platform/mellanox: mlxreg-lc: Fix error flow and extend verbosity")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20220823201937.46855-2-vadimp@nvidia.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/mellanox/mlxreg-lc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c index 55834ccb4ac7..9a1bfcd24317 100644 --- a/drivers/platform/mellanox/mlxreg-lc.c +++ b/drivers/platform/mellanox/mlxreg-lc.c @@ -863,7 +863,6 @@ static int mlxreg_lc_probe(struct platform_device *pdev) if (err) { dev_err(&pdev->dev, "Failed to sync regmap for client %s at bus %d at addr 0x%02x\n", data->hpdev.brdinfo->type, data->hpdev.nr, data->hpdev.brdinfo->addr); - err = PTR_ERR(regmap); goto regcache_sync_fail; } |