diff options
| author | Young Xiao <92siuyang@gmail.com> | 2019-05-29 10:43:58 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2019-06-08 01:29:42 +0200 |
| commit | f38b5069234937ae818d6a39fd4dc03d003b5565 (patch) | |
| tree | 374a0cfeecf4360510bb0013fa37aa524702116f /drivers/pinctrl | |
| parent | 3a11cf2217520e3c827a24c6d5f648fa45845787 (diff) | |
| download | lwn-f38b5069234937ae818d6a39fd4dc03d003b5565.tar.gz lwn-f38b5069234937ae818d6a39fd4dc03d003b5565.zip | |
pinctrl: ns2: Fix potential NULL dereference
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.
Signed-off-by: Young Xiao <92siuyang@gmail.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 4b5cf0e0f16e..2bf6af7df7d9 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -1048,6 +1048,8 @@ static int ns2_pinmux_probe(struct platform_device *pdev) return PTR_ERR(pinctrl->base0); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); + if (!res) + return -EINVAL; pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start, resource_size(res)); if (!pinctrl->base1) { |