diff options
| author | Qian Cai <cai@lca.pw> | 2019-10-31 10:05:19 -0400 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2019-11-17 09:17:38 -0800 |
| commit | 4e24e37d5313edca8b4ab86f240c046c731e28d6 (patch) | |
| tree | c62b91db39f9c42f626b8b298f3cf5b8a914e914 /drivers/nvdimm | |
| parent | d7c0d927ad5ca452201eae40f932712ac733c816 (diff) | |
| download | lwn-4e24e37d5313edca8b4ab86f240c046c731e28d6.tar.gz lwn-4e24e37d5313edca8b4ab86f240c046c731e28d6.zip | |
libnvdimm/btt: fix variable 'rc' set but not used
drivers/nvdimm/btt.c: In function 'btt_read_pg':
drivers/nvdimm/btt.c:1264:8: warning: variable 'rc' set but not used
[-Wunused-but-set-variable]
int rc;
^~
Add a ratelimited message in case a storm of errors is encountered.
Fixes: d9b83c756953 ("libnvdimm, btt: rework error clearing")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Link: https://lore.kernel.org/r/1572530719-32161-1-git-send-email-cai@lca.pw
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm')
| -rw-r--r-- | drivers/nvdimm/btt.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 8cb890a987b0..0d04ea3d9fd7 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1261,11 +1261,11 @@ static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip, ret = btt_data_read(arena, page, off, postmap, cur_len); if (ret) { - int rc; - /* Media error - set the e_flag */ - rc = btt_map_write(arena, premap, postmap, 0, 1, - NVDIMM_IO_ATOMIC); + if (btt_map_write(arena, premap, postmap, 0, 1, NVDIMM_IO_ATOMIC)) + dev_warn_ratelimited(to_dev(arena), + "Error persistently tracking bad blocks at %#x\n", + premap); goto out_rtt; } |