summaryrefslogtreecommitdiff
path: root/drivers/nvdimm
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2020-02-25 19:20:06 +0300
committerDan Williams <dan.j.williams@intel.com>2020-02-28 18:21:52 -0800
commit01091c496f920e634ea84b689f480c39016752a8 (patch)
treed099cc67c80a8977c3e8fbe729b51667effa4534 /drivers/nvdimm
parentc0e71d602053e4e7637e4bc7d0bc9603ea77a33f (diff)
downloadlwn-01091c496f920e634ea84b689f480c39016752a8.tar.gz
lwn-01091c496f920e634ea84b689f480c39016752a8.zip
acpi/nfit: improve bounds checking for 'func'
The 'func' variable can come from the user in the __nd_ioctl(). If it's too high then the (1 << func) shift in acpi_nfit_clear_to_send() is undefined. In acpi_nfit_ctl() we pass 'func' to test_bit(func, &dsm_mask) which could result in an out of bounds access. To fix these issues, I introduced the NVDIMM_CMD_MAX (31) define and updated nfit_dsm_revid() to use that define as well instead of magic numbers. Fixes: 11189c1089da ("acpi/nfit: Fix command-supported detection") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Dan Williams <dan.j.williams@intel.com> Link: https://lore.kernel.org/r/20200225161927.hvftuq7kjn547fyj@kili.mountain Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm')
0 files changed, 0 insertions, 0 deletions