diff options
| author | Konstantin Meskhidze <konstantin.meskhidze@huawei.com> | 2023-08-17 19:59:45 +0800 |
|---|---|---|
| committer | Dave Jiang <dave.jiang@intel.com> | 2023-08-17 09:34:02 -0700 |
| commit | 85ae42c72142346645e63c33835da947dfa008b3 (patch) | |
| tree | ce7b5dda2c2224ba161b05ba5c38703b8e5bb8b0 /drivers/nvdimm/nd_perf.c | |
| parent | feb72e9b20823419aaed57801018eeffc7be7e82 (diff) | |
| download | lwn-85ae42c72142346645e63c33835da947dfa008b3.tar.gz lwn-85ae42c72142346645e63c33835da947dfa008b3.zip | |
nvdimm: Fix memleak of pmu attr_groups in unregister_nvdimm_pmu()
Memory pointed by 'nd_pmu->pmu.attr_groups' is allocated in function
'register_nvdimm_pmu' and is lost after 'kfree(nd_pmu)' call in function
'unregister_nvdimm_pmu'.
Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose nvdimm performance stats")
Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Link: https://lore.kernel.org/r/20230817115945.771826-1-konstantin.meskhidze@huawei.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'drivers/nvdimm/nd_perf.c')
| -rw-r--r-- | drivers/nvdimm/nd_perf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c index 433bbb68ae64..14881c4e03e6 100644 --- a/drivers/nvdimm/nd_perf.c +++ b/drivers/nvdimm/nd_perf.c @@ -324,6 +324,7 @@ void unregister_nvdimm_pmu(struct nvdimm_pmu *nd_pmu) { perf_pmu_unregister(&nd_pmu->pmu); nvdimm_pmu_free_hotplug_memory(nd_pmu); + kfree(nd_pmu->pmu.attr_groups); kfree(nd_pmu); } EXPORT_SYMBOL_GPL(unregister_nvdimm_pmu); |