diff options
| author | Martin Faltesek <mfaltesek@google.com> | 2022-11-21 18:42:44 -0600 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-11-23 20:01:50 -0800 |
| commit | c60c152230828825c06e62a8f1ce956d4b659266 (patch) | |
| tree | d3220c3d64ca4812ead6b4df17eea6ec2b8af112 /drivers/nfc | |
| parent | 06ccc8ec701e4d685c9572e4251cd9735c6e9b49 (diff) | |
| download | lwn-c60c152230828825c06e62a8f1ce956d4b659266.tar.gz lwn-c60c152230828825c06e62a8f1ce956d4b659266.zip | |
nfc: st-nci: fix incorrect validating logic in EVT_TRANSACTION
The first validation check for EVT_TRANSACTION has two different checks
tied together with logical AND. One is a check for minimum packet length,
and the other is for a valid aid_tag. If either condition is true (fails),
then an error should be triggered. The fix is to change && to ||.
Reported-by: Denis Efremov <denis.e.efremov@oracle.com>
Reviewed-by: Guenter Roeck <groeck@google.com>
Fixes: 5d1ceb7f5e56 ("NFC: st21nfcb: Add HCI transaction event support")
Signed-off-by: Martin Faltesek <mfaltesek@google.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/nfc')
| -rw-r--r-- | drivers/nfc/st-nci/se.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c index 7764b1a4c3cf..589e1dec78e7 100644 --- a/drivers/nfc/st-nci/se.c +++ b/drivers/nfc/st-nci/se.c @@ -326,7 +326,7 @@ static int st_nci_hci_connectivity_event_received(struct nci_dev *ndev, * AID 81 5 to 16 * PARAMETERS 82 0 to 255 */ - if (skb->len < NFC_MIN_AID_LENGTH + 2 && + if (skb->len < NFC_MIN_AID_LENGTH + 2 || skb->data[0] != NFC_EVT_TRANSACTION_AID_TAG) return -EPROTO; |