summaryrefslogtreecommitdiff
path: root/drivers/net/virtio_net.c
diff options
context:
space:
mode:
authorXuan Zhuo <xuanzhuo@linux.alibaba.com>2024-02-23 15:18:33 +0800
committerMichael S. Tsirkin <mst@redhat.com>2024-03-19 03:19:22 -0400
commitd5c0ed17fea60cca9bc3bf1278b49ba79242bbcd (patch)
tree955afedd4d931a06f0c2e63e120a56ca4a943370 /drivers/net/virtio_net.c
parent1ac61ddfee93278f87370f6c43ed669b845f9037 (diff)
downloadlwn-d5c0ed17fea60cca9bc3bf1278b49ba79242bbcd.tar.gz
lwn-d5c0ed17fea60cca9bc3bf1278b49ba79242bbcd.zip
virtio: packed: fix unmap leak for indirect desc table
When use_dma_api and premapped are true, then the do_unmap is false. Because the do_unmap is false, vring_unmap_extra_packed is not called by detach_buf_packed. if (unlikely(vq->do_unmap)) { curr = id; for (i = 0; i < state->num; i++) { vring_unmap_extra_packed(vq, &vq->packed.desc_extra[curr]); curr = vq->packed.desc_extra[curr].next; } } So the indirect desc table is not unmapped. This causes the unmap leak. So here, we check vq->use_dma_api instead. Synchronously, dma info is updated based on use_dma_api judgment This bug does not occur, because no driver use the premapped with indirect. Fixes: b319940f83c2 ("virtio_ring: skip unmap for premapped") Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Message-Id: <20240223071833.26095-1-xuanzhuo@linux.alibaba.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/net/virtio_net.c')
0 files changed, 0 insertions, 0 deletions