diff options
| author | David S. Miller <davem@davemloft.net> | 2008-06-12 02:22:02 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-06-12 02:22:02 -0700 |
| commit | 4bb073c0e32a0862bdb5215d11af19f6c0180c98 (patch) | |
| tree | 009d95592e3813346c75129bb19d140d393ca913 /drivers/net/usb/kaweth.c | |
| parent | 7afb380db43ed137b7f67e0e3c3e5afd1ecde730 (diff) | |
| download | lwn-4bb073c0e32a0862bdb5215d11af19f6c0180c98.tar.gz lwn-4bb073c0e32a0862bdb5215d11af19f6c0180c98.zip | |
net: Eliminate flush_scheduled_work() calls while RTNL is held.
If the RTNL is held when we invoke flush_scheduled_work() we could
deadlock. One such case is linkwatch, it is a work struct which tries
to grab the RTNL semaphore.
The most common case are net driver ->stop() methods. The
simplest conversion is to instead use cancel_{delayed_}work_sync()
explicitly on the various work struct the driver uses.
This is an OK transformation because these work structs are doing
things like resetting the chip, restarting link negotiation, and so
forth. And if we're bringing down the device, we're about to turn the
chip off and reset it anways. So if we cancel a pending work event,
that's fine here.
Some drivers were working around this deadlock by using a msleep()
polling loop of some sort, and those cases are converted to instead
use cancel_{delayed_}work_sync() as well.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/kaweth.c')
| -rw-r--r-- | drivers/net/usb/kaweth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 0dcfc0310264..7c66b052f55a 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -706,7 +706,7 @@ static void kaweth_kill_urbs(struct kaweth_device *kaweth) usb_kill_urb(kaweth->rx_urb); usb_kill_urb(kaweth->tx_urb); - flush_scheduled_work(); + cancel_delayed_work_sync(&kaweth->lowmem_work); /* a scheduled work may have resubmitted, we hit them again */ |