diff options
| author | Florian Westphal <fw@strlen.de> | 2022-08-07 13:53:04 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-08-09 12:16:02 -0700 |
| commit | bc3c8fe3c79bcdae4d90e3726054fac5cca8ac32 (patch) | |
| tree | 9f91653a542de5b1366d5b8e0d5edd8e22fbec36 /drivers/net/plip | |
| parent | 1b7680c6c1f6de9904f1d9b05c952f0c64a03350 (diff) | |
| download | lwn-bc3c8fe3c79bcdae4d90e3726054fac5cca8ac32.tar.gz lwn-bc3c8fe3c79bcdae4d90e3726054fac5cca8ac32.zip | |
plip: avoid rcu debug splat
WARNING: suspicious RCU usage
5.2.0-rc2-00605-g2638eb8b50cfc #1 Not tainted
drivers/net/plip/plip.c:1110 suspicious rcu_dereference_check() usage!
plip_open is called with RTNL held, switch to the correct helper.
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Link: https://lore.kernel.org/r/20220807115304.13257-1-fw@strlen.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/plip')
| -rw-r--r-- | drivers/net/plip/plip.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c index dafd3e9ebbf8..c8791e9b451d 100644 --- a/drivers/net/plip/plip.c +++ b/drivers/net/plip/plip.c @@ -1111,7 +1111,7 @@ plip_open(struct net_device *dev) /* Any address will do - we take the first. We already have the first two bytes filled with 0xfc, from plip_init_dev(). */ - const struct in_ifaddr *ifa = rcu_dereference(in_dev->ifa_list); + const struct in_ifaddr *ifa = rtnl_dereference(in_dev->ifa_list); if (ifa != NULL) { dev_addr_mod(dev, 2, &ifa->ifa_local, 4); } |