diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 13:54:59 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-09-27 10:00:16 +0200 |
| commit | 286183147666fb76c057836c57d86e9e6f508bca (patch) | |
| tree | f6ad0db8593ef65469be8654c5be82178c552cd5 /drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | |
| parent | 31aefe14bc9f56566041303d733fda511d3a1c3e (diff) | |
| download | lwn-286183147666fb76c057836c57d86e9e6f508bca.tar.gz lwn-286183147666fb76c057836c57d86e9e6f508bca.zip | |
cxgb4: Signedness bug in init_one()
The "chip" variable is an enum, and it's treated as unsigned int by GCC
in this context so the error handling isn't triggered.
Fixes: e8d452923ae6 ("cxgb4: clean up init_one")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c')
| -rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 71854a19cebe..38024877751c 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -5701,7 +5701,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) whoami = t4_read_reg(adapter, PL_WHOAMI_A); pci_read_config_word(pdev, PCI_DEVICE_ID, &device_id); chip = t4_get_chip_type(adapter, CHELSIO_PCI_ID_VER(device_id)); - if (chip < 0) { + if ((int)chip < 0) { dev_err(&pdev->dev, "Device %d is not supported\n", device_id); err = chip; goto out_free_adapter; |