diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2018-06-27 11:20:52 +0200 |
|---|---|---|
| committer | Jacek Anaszewski <jacek.anaszewski@gmail.com> | 2018-06-28 21:34:45 +0200 |
| commit | 30f3b42147ba6f29bc95c1bba34468740762d91b (patch) | |
| tree | 4e6bf9b631ef729b7f374a0016835dbdda46476e /drivers/net/can/Kconfig | |
| parent | 868ec1cad0d93365ddbb1cba2b671c6c8c9221ba (diff) | |
| download | lwn-30f3b42147ba6f29bc95c1bba34468740762d91b.tar.gz lwn-30f3b42147ba6f29bc95c1bba34468740762d91b.zip | |
can: mark led trigger as broken
The driver was suggested for deletion as it implements a subset of the
netdev trigger. It's in the way for further cleanups in the trigger
code but doesn't get an Ack by someone who can actually test and confirm
that the netdev trigger works for can devices. So marking as broken to
get forward with the cleanups.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Diffstat (limited to 'drivers/net/can/Kconfig')
| -rw-r--r-- | drivers/net/can/Kconfig | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 2cb75988b328..7cdd0cead693 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -73,6 +73,12 @@ config CAN_CALC_BITTIMING config CAN_LEDS bool "Enable LED triggers for Netlink based drivers" depends on LEDS_CLASS + # The netdev trigger (LEDS_TRIGGER_NETDEV) should be able to do + # everything that this driver is doing. This is marked as broken + # because it uses stuff that is intended to be changed or removed. + # Please consider switching to the netdev trigger and confirm it + # fulfills your needs instead of fixing this driver. + depends on BROKEN select LEDS_TRIGGERS ---help--- This option adds two LED triggers for packet receive and transmit |