diff options
| author | Ricardo Ribalda <ribalda@chromium.org> | 2024-04-11 21:17:53 +0000 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2024-04-15 13:42:38 +0200 |
| commit | cf8da3293b0b86c08e960c020cd667bd878c42d6 (patch) | |
| tree | 8f37644a969001579bc94efa7358c8c644ac3f63 /drivers/media/platform | |
| parent | 179559ed315558018208f3749931b960b8e4a707 (diff) | |
| download | lwn-cf8da3293b0b86c08e960c020cd667bd878c42d6.tar.gz lwn-cf8da3293b0b86c08e960c020cd667bd878c42d6.zip | |
media: c8sectpfe: Refactor load_c8sectpfe_fw
release_firmware() in the same function that it was requested. It is
more clear and makes smatch happy.
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1146 load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines: 1125,1132.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/platform')
| -rw-r--r-- | drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c index 0df2a1b4974b..2f58a0d0df85 100644 --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c @@ -1096,7 +1096,6 @@ static int load_slim_core_fw(const struct firmware *fw, struct c8sectpfei *fei) } } - release_firmware(fw); return err; } @@ -1120,6 +1119,7 @@ static int load_c8sectpfe_fw(struct c8sectpfei *fei) } err = load_slim_core_fw(fw, fei); + release_firmware(fw); if (err) { dev_err(fei->dev, "load_slim_core_fw failed err=(%d)\n", err); return err; |