diff options
| author | NeilBrown <neilb@suse.com> | 2017-06-18 14:38:57 +1000 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2017-06-18 12:40:59 -0600 |
| commit | 011067b05668b05aae88e5a24cff0ca0a67ca0b0 (patch) | |
| tree | b56fb4114e8bd71ffd36520f1b4cf7e4e49f1c79 /drivers/md/raid5-ppl.c | |
| parent | af67c31fba3b879b241536a48df703a2eee18ebf (diff) | |
| download | lwn-011067b05668b05aae88e5a24cff0ca0a67ca0b0.tar.gz lwn-011067b05668b05aae88e5a24cff0ca0a67ca0b0.zip | |
blk: replace bioset_create_nobvec() with a flags arg to bioset_create()
"flags" arguments are often seen as good API design as they allow
easy extensibility.
bioset_create_nobvec() is implemented internally as a variation in
flags passed to __bioset_create().
To support future extension, make the internal structure part of the
API.
i.e. add a 'flags' argument to bioset_create() and discard
bioset_create_nobvec().
Note that the bio_split allocations in drivers/md/raid* do not need
the bvec mempool - they should have used bioset_create_nobvec().
Suggested-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/raid5-ppl.c')
| -rw-r--r-- | drivers/md/raid5-ppl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c index e709ada0bf09..77cce3573aa8 100644 --- a/drivers/md/raid5-ppl.c +++ b/drivers/md/raid5-ppl.c @@ -1150,7 +1150,7 @@ int ppl_init_log(struct r5conf *conf) goto err; } - ppl_conf->bs = bioset_create(conf->raid_disks, 0); + ppl_conf->bs = bioset_create(conf->raid_disks, 0, 0); if (!ppl_conf->bs) { ret = -ENOMEM; goto err; |