diff options
| author | Nick Bowler <nbowler@draconx.ca> | 2024-07-10 23:54:17 -0400 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2024-07-11 17:32:31 +1000 |
| commit | fd748e177194ebcbbaf98df75152a30e08230cc6 (patch) | |
| tree | fc4aea51c960b823d12be1ed641b6be122c2f0a7 /drivers/macintosh | |
| parent | db25a9625dbc3aa6613c0347f574689c248a3d0b (diff) | |
| download | lwn-fd748e177194ebcbbaf98df75152a30e08230cc6.tar.gz lwn-fd748e177194ebcbbaf98df75152a30e08230cc6.zip | |
macintosh/therm_windtunnel: fix module unload.
The of_device_unregister call in therm_windtunnel's module_exit procedure
does not fully reverse the effects of of_platform_device_create in the
module_init prodedure. Once you unload this module, it is impossible
to load it ever again since only the first of_platform_device_create
call on the fan node succeeds.
This driver predates first git commit, and it turns out back then
of_platform_device_create worked differently than it does today.
So this is actually an old regression.
The appropriate function to undo of_platform_device_create now appears
to be of_platform_device_destroy, and switching to use this makes it
possible to unload and load the module as expected.
Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Fixes: c6e126de43e7 ("of: Keep track of populated platform devices")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240711035428.16696-1-nbowler@draconx.ca
Diffstat (limited to 'drivers/macintosh')
| -rw-r--r-- | drivers/macintosh/therm_windtunnel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm_windtunnel.c index 37cdc6931f6d..2576a53f247e 100644 --- a/drivers/macintosh/therm_windtunnel.c +++ b/drivers/macintosh/therm_windtunnel.c @@ -549,7 +549,7 @@ g4fan_exit( void ) platform_driver_unregister( &therm_of_driver ); if( x.of_dev ) - of_device_unregister( x.of_dev ); + of_platform_device_destroy(&x.of_dev->dev, NULL); } module_init(g4fan_init); |