diff options
| author | Arvind Yadav <arvind.yadav.cs@gmail.com> | 2017-11-16 09:57:23 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-11-16 22:31:16 +0900 |
| commit | faa2efff3dfa4f03cfdbf86e77cd94b16f1fbdf8 (patch) | |
| tree | 3773a901e1160a7a16e126e4a7fed421817ae847 /drivers/isdn | |
| parent | a6234b89658702ffb1368fcbdcab1b66b2672244 (diff) | |
| download | lwn-faa2efff3dfa4f03cfdbf86e77cd94b16f1fbdf8.tar.gz lwn-faa2efff3dfa4f03cfdbf86e77cd94b16f1fbdf8.zip | |
isdn: hisax: Fix pnp_irq's error checking for setup_hfcs
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/hisax/hfcscard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hisax/hfcscard.c b/drivers/isdn/hisax/hfcscard.c index 380bbeda9c74..91b5219499ca 100644 --- a/drivers/isdn/hisax/hfcscard.c +++ b/drivers/isdn/hisax/hfcscard.c @@ -196,7 +196,7 @@ int setup_hfcs(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); |