diff options
| author | Pan Bian <bianpan2016@163.com> | 2016-12-03 17:24:17 +0800 |
|---|---|---|
| committer | Jonathan Cameron <jic23@kernel.org> | 2016-12-04 10:56:26 +0000 |
| commit | db4e5376d058af8924fafd0520a0942d92538d0e (patch) | |
| tree | 0de1b824060da297887ab82d156f41b7ae9a7c6d /drivers/iio/light/cm3232.c | |
| parent | 67351df7f134d2f0de9a8602e9351f59b7fd64b0 (diff) | |
| download | lwn-db4e5376d058af8924fafd0520a0942d92538d0e.tar.gz lwn-db4e5376d058af8924fafd0520a0942d92538d0e.zip | |
iio: light: fix improper return value
In function cm3232_reg_init(), it returns 0 even if the last call to
i2c_smbus_write_byte_data() returns a negative value (indicates error).
As a result, the return value may be inconsistent with the execution
status, and the caller of cm3232_reg_init() will not be able to detect
the error. This patch fixes the bug.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/light/cm3232.c')
| -rw-r--r-- | drivers/iio/light/cm3232.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/light/cm3232.c b/drivers/iio/light/cm3232.c index fe89b6823217..263e97235ea0 100644 --- a/drivers/iio/light/cm3232.c +++ b/drivers/iio/light/cm3232.c @@ -119,7 +119,7 @@ static int cm3232_reg_init(struct cm3232_chip *chip) if (ret < 0) dev_err(&chip->client->dev, "Error writing reg_cmd\n"); - return 0; + return ret; } /** |