diff options
| author | Jarkko Nikula <jarkko.nikula@linux.intel.com> | 2023-09-21 08:57:02 +0300 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2023-09-25 23:35:14 +0200 |
| commit | 4c36f656b7d1fc00643730c5845c19b3e15be856 (patch) | |
| tree | a19fc5478f4d470d8e4129c3389592e2003db4ee /drivers/i3c | |
| parent | b8806e0c939f168237593af0056c309bf31022b0 (diff) | |
| download | lwn-4c36f656b7d1fc00643730c5845c19b3e15be856.tar.gz lwn-4c36f656b7d1fc00643730c5845c19b3e15be856.zip | |
i3c: mipi-i3c-hci: Fix missing xfer->completion in hci_cmd_v1_daa()
Due to missing completion object for the ENTDAA command transfer in the
hci_cmd_v1_daa() the wait_for_completion_timeout() will obviously
timeout even the transfer itself may succeed.
Fix this by setting the xfer->completion to the already initialized
completion object.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20230921055704.1087277-11-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/i3c')
| -rw-r--r-- | drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c index 6a781f89b0e4..2b2323aa6714 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c @@ -332,6 +332,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci) CMD_A0_DEV_COUNT(1) | CMD_A0_ROC | CMD_A0_TOC; xfer->cmd_desc[1] = 0; + xfer->completion = &done; hci->io->queue_xfer(hci, xfer, 1); if (!wait_for_completion_timeout(&done, HZ) && hci->io->dequeue_xfer(hci, xfer, 1)) { |