diff options
| author | Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> | 2020-06-25 13:32:42 +0900 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2020-06-25 16:06:06 -0700 |
| commit | 8b97f9922211c44a739c5cbd9502ecbb9f17f6d1 (patch) | |
| tree | 2904c7078b62cf6ab185cbb9331f4388ff860817 /drivers/hwmon/acpi_power_meter.c | |
| parent | 016983d138cbe99a5c0aaae0103ee88f5300beb3 (diff) | |
| download | lwn-8b97f9922211c44a739c5cbd9502ecbb9f17f6d1.tar.gz lwn-8b97f9922211c44a739c5cbd9502ecbb9f17f6d1.zip | |
hwmon: (acpi_power_meter) Fix potential memory leak in acpi_power_meter_add()
Although it rarely happens, we should call free_capabilities()
if error happens after read_capabilities() to free allocated strings.
Fixes: de584afa5e188 ("hwmon driver for ACPI 4.0 power meters")
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Link: https://lore.kernel.org/r/20200625043242.31175-1-misono.tomohiro@jp.fujitsu.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/acpi_power_meter.c')
| -rw-r--r-- | drivers/hwmon/acpi_power_meter.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c index 0db8ef4fd6e1..a270b975e90b 100644 --- a/drivers/hwmon/acpi_power_meter.c +++ b/drivers/hwmon/acpi_power_meter.c @@ -883,7 +883,7 @@ static int acpi_power_meter_add(struct acpi_device *device) res = setup_attrs(resource); if (res) - goto exit_free; + goto exit_free_capability; resource->hwmon_dev = hwmon_device_register(&device->dev); if (IS_ERR(resource->hwmon_dev)) { @@ -896,6 +896,8 @@ static int acpi_power_meter_add(struct acpi_device *device) exit_remove: remove_attrs(resource); +exit_free_capability: + free_capabilities(resource); exit_free: kfree(resource); exit: |