diff options
| author | Maximilian Luz <luzmaximilian@gmail.com> | 2021-04-11 13:34:02 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2021-05-05 14:31:55 +0200 |
| commit | b0d713c60c75cdd04bf8ad8cfb046c8530709de3 (patch) | |
| tree | e6ce720d17cb5f36f60749b591fa923475743726 /drivers/hid/surface-hid | |
| parent | 0f0fb3d27e5ba51e40f2af4288efeaf3d293ef1a (diff) | |
| download | lwn-b0d713c60c75cdd04bf8ad8cfb046c8530709de3.tar.gz lwn-b0d713c60c75cdd04bf8ad8cfb046c8530709de3.zip | |
HID: surface-hid: Fix integer endian conversion
We want to convert from 16 bit (unsigned) little endian values contained
in a packed struct to CPU native endian values here, not the other way
around. So replace cpu_to_le16() with get_unaligned_le16(), using the
latter instead of le16_to_cpu() to acknowledge that we are reading from
a packed struct.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: b05ff1002a5c ("HID: Add support for Surface Aggregator Module HID transport")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/surface-hid')
| -rw-r--r-- | drivers/hid/surface-hid/surface_hid_core.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hid/surface-hid/surface_hid_core.c b/drivers/hid/surface-hid/surface_hid_core.c index 7b27ec392232..5571e74abe91 100644 --- a/drivers/hid/surface-hid/surface_hid_core.c +++ b/drivers/hid/surface-hid/surface_hid_core.c @@ -168,9 +168,9 @@ int surface_hid_device_add(struct surface_hid_device *shid) shid->hid->dev.parent = shid->dev; shid->hid->bus = BUS_HOST; - shid->hid->vendor = cpu_to_le16(shid->attrs.vendor); - shid->hid->product = cpu_to_le16(shid->attrs.product); - shid->hid->version = cpu_to_le16(shid->hid_desc.hid_version); + shid->hid->vendor = get_unaligned_le16(&shid->attrs.vendor); + shid->hid->product = get_unaligned_le16(&shid->attrs.product); + shid->hid->version = get_unaligned_le16(&shid->hid_desc.hid_version); shid->hid->country = shid->hid_desc.country_code; snprintf(shid->hid->name, sizeof(shid->hid->name), "Microsoft Surface %04X:%04X", |