diff options
| author | Axel Lin <axel.lin@gmail.com> | 2012-09-14 06:15:36 +0800 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2012-09-19 13:57:03 +0200 |
| commit | 206e3f1cda4d6113bdbb3656917d481b9ad447e4 (patch) | |
| tree | fd6be59466b5e473baa16f08dfcb7a9334fb6b98 /drivers/hid/hid-picolcd_core.c | |
| parent | bb5c32d99899b0c5c46c4b0d3165de66a6981f8a (diff) | |
| download | lwn-206e3f1cda4d6113bdbb3656917d481b9ad447e4.tar.gz lwn-206e3f1cda4d6113bdbb3656917d481b9ad447e4.zip | |
HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start()
Current implementation of hid_hw_start() allows connect_mask to be 0.
Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not
necessary. Remove it.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-By: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-picolcd_core.c')
| -rw-r--r-- | drivers/hid/hid-picolcd_core.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index bd2a75185cb3..86df26e58aba 100644 --- a/drivers/hid/hid-picolcd_core.c +++ b/drivers/hid/hid-picolcd_core.c @@ -565,11 +565,7 @@ static int picolcd_probe(struct hid_device *hdev, goto err_cleanup_data; } - /* We don't use hidinput but hid_hw_start() fails if nothing is - * claimed. So spoof claimed input. */ - hdev->claimed = HID_CLAIMED_INPUT; error = hid_hw_start(hdev, 0); - hdev->claimed = 0; if (error) { hid_err(hdev, "hardware start failed\n"); goto err_cleanup_data; |