diff options
| author | Bastien Nocera <hadess@hadess.net> | 2023-05-31 10:24:28 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2023-05-31 16:08:24 +0200 |
| commit | 6199d23c91ce53bfed455f09a8c5ed170d516824 (patch) | |
| tree | bdca9b3a269da8191bf336bb9f165ff8f751454b /drivers/hid/hid-logitech-hidpp.c | |
| parent | 16a9c24f24fbe4564284eb575b18cc20586b9270 (diff) | |
| download | lwn-6199d23c91ce53bfed455f09a8c5ed170d516824.tar.gz lwn-6199d23c91ce53bfed455f09a8c5ed170d516824.zip | |
HID: logitech-hidpp: Handle timeout differently from busy
If an attempt at contacting a receiver or a device fails because the
receiver or device never responds, don't restart the communication, only
restart it if the receiver or device answers that it's busy, as originally
intended.
This was the behaviour on communication timeout before commit 586e8fede795
("HID: logitech-hidpp: Retry commands when device is busy").
This fixes some overly long waits in a critical path on boot, when
checking whether the device is connected by getting its HID++ version.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Suggested-by: Mark Lord <mlord@pobox.com>
Fixes: 586e8fede795 ("HID: logitech-hidpp: Retry commands when device is busy")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217412
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-logitech-hidpp.c')
| -rw-r--r-- | drivers/hid/hid-logitech-hidpp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 0fcfd85fea0f..2246044b1639 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -314,6 +314,7 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp, dbg_hid("%s:timeout waiting for response\n", __func__); memset(response, 0, sizeof(struct hidpp_report)); ret = -ETIMEDOUT; + goto exit; } if (response->report_id == REPORT_ID_HIDPP_SHORT && |