diff options
| author | Matthew Brost <matthew.brost@intel.com> | 2024-07-26 18:22:16 -0700 |
|---|---|---|
| committer | Matthew Brost <matthew.brost@intel.com> | 2024-07-30 18:44:10 -0700 |
| commit | 7f7a2da3bf8bc0e0f6c239af495b7050056e889c (patch) | |
| tree | 6d923ebfb0ee6b3db7eb0f133dedf3fdb598d596 /drivers/gpu/drm/xe/xe_sync.c | |
| parent | f2881dfdaaa9ec873dbd383ef5512fc31e576cbb (diff) | |
| download | lwn-7f7a2da3bf8bc0e0f6c239af495b7050056e889c.tar.gz lwn-7f7a2da3bf8bc0e0f6c239af495b7050056e889c.zip | |
drm/xe: Use dma_fence_chain_free in chain fence unused as a sync
A chain fence is uninitialized if not installed in a drm sync obj. Thus
if xe_sync_entry_cleanup is called and sync->chain_fence is non-NULL the
proper cleanup is dma_fence_chain_free rather than a dma-fence put.
Reported-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2411
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2261
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240727012216.2118276-1-matthew.brost@intel.com
Diffstat (limited to 'drivers/gpu/drm/xe/xe_sync.c')
| -rw-r--r-- | drivers/gpu/drm/xe/xe_sync.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c index 533246f42256..3aa6270e5dd7 100644 --- a/drivers/gpu/drm/xe/xe_sync.c +++ b/drivers/gpu/drm/xe/xe_sync.c @@ -259,7 +259,7 @@ void xe_sync_entry_cleanup(struct xe_sync_entry *sync) if (sync->fence) dma_fence_put(sync->fence); if (sync->chain_fence) - dma_fence_put(&sync->chain_fence->base); + dma_fence_chain_free(sync->chain_fence); if (sync->ufence) user_fence_put(sync->ufence); } |