diff options
| author | Matthew Brost <matthew.brost@intel.com> | 2024-01-31 16:48:48 -0800 |
|---|---|---|
| committer | Matthew Brost <matthew.brost@intel.com> | 2024-02-02 06:45:57 -0800 |
| commit | a856b67a84169e065ebbeee50258936b1eacc9eb (patch) | |
| tree | 7fca946332e8ca3d1b7869e7b3a1e2aff0bac4bd /drivers/gpu/drm/xe/xe_migrate.c | |
| parent | 5fcbf83e39ecde8e54c0b3da3a755a306a0ac348 (diff) | |
| download | lwn-a856b67a84169e065ebbeee50258936b1eacc9eb.tar.gz lwn-a856b67a84169e065ebbeee50258936b1eacc9eb.zip | |
drm/xe: Take a reference in xe_exec_queue_last_fence_get()
Take a reference in xe_exec_queue_last_fence_get(). Also fix a reference
counting underflow bug VM bind and unbind.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240201004849.2219558-2-matthew.brost@intel.com
Diffstat (limited to 'drivers/gpu/drm/xe/xe_migrate.c')
| -rw-r--r-- | drivers/gpu/drm/xe/xe_migrate.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c index 9ab004871f9a..894e36c28f32 100644 --- a/drivers/gpu/drm/xe/xe_migrate.c +++ b/drivers/gpu/drm/xe/xe_migrate.c @@ -1214,8 +1214,11 @@ static bool no_in_syncs(struct xe_vm *vm, struct xe_exec_queue *q, } if (q) { fence = xe_exec_queue_last_fence_get(q, vm); - if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) + if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { + dma_fence_put(fence); return false; + } + dma_fence_put(fence); } return true; |