diff options
| author | Christoph Hellwig <hch@lst.de> | 2024-07-19 06:07:38 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2024-08-29 07:22:49 +0300 |
| commit | 334304ac2baca7f3e821c47cf5129d90e7a6b1e6 (patch) | |
| tree | 97bf1f87e108962f636331aa4f9ac4b0a5627a96 /drivers/gpu/drm/mediatek | |
| parent | 560a861ab4174b42240157ab5cebe36b8c7bc418 (diff) | |
| download | lwn-334304ac2baca7f3e821c47cf5129d90e7a6b1e6.tar.gz lwn-334304ac2baca7f3e821c47cf5129d90e7a6b1e6.zip | |
dma-mapping: don't return errors from dma_set_max_seg_size
A NULL dev->dma_parms indicates either a bus that is not DMA capable or
grave bug in the implementation of the bus code.
There isn't much the driver can do in terms of error handling for either
case, so just warn and continue as DMA operations will fail anyway.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC
Diffstat (limited to 'drivers/gpu/drm/mediatek')
| -rw-r--r-- | drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 77b50c56c124..3e807195a0d0 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -559,11 +559,7 @@ static int mtk_drm_kms_init(struct drm_device *drm) * Configure the DMA segment size to make sure we get contiguous IOVA * when importing PRIME buffers. */ - ret = dma_set_max_seg_size(dma_dev, UINT_MAX); - if (ret) { - dev_err(dma_dev, "Failed to set DMA segment size\n"); - goto err_component_unbind; - } + dma_set_max_seg_size(dma_dev, UINT_MAX); ret = drm_vblank_init(drm, MAX_CRTC); if (ret < 0) |