diff options
| author | Biju Das <biju.das.jz@bp.renesas.com> | 2024-06-25 18:01:16 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-06-28 12:49:27 +0530 |
| commit | 0e53aa3464e9a0a82bd3b926ba5999a11569c9ba (patch) | |
| tree | 768d882453ce19a6b206160af3153c5fbb96d269 /drivers/dma | |
| parent | 73115d8068b6ed59e9d728bb9067462084f02a25 (diff) | |
| download | lwn-0e53aa3464e9a0a82bd3b926ba5999a11569c9ba.tar.gz lwn-0e53aa3464e9a0a82bd3b926ba5999a11569c9ba.zip | |
dmaengine: sh: rz-dmac: Fix lockdep assert warning
Fix the below lockdep assert warning by holding vc.lock for
vchan_get_all_descriptors().
WARNING: virt-dma.h:188 rz_dmac_terminate_all
pc : rz_dmac_terminate_all
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240625170119.173595-1-biju.das.jz@bp.renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/sh/rz-dmac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 1f1e86ba5c66..65a27c5a7bce 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -540,8 +540,8 @@ static int rz_dmac_terminate_all(struct dma_chan *chan) spin_lock_irqsave(&channel->vc.lock, flags); list_splice_tail_init(&channel->ld_active, &channel->ld_free); list_splice_tail_init(&channel->ld_queue, &channel->ld_free); - spin_unlock_irqrestore(&channel->vc.lock, flags); vchan_get_all_descriptors(&channel->vc, &head); + spin_unlock_irqrestore(&channel->vc.lock, flags); vchan_dma_desc_free_list(&channel->vc, &head); return 0; |