diff options
| author | Lin Yujun <linyujun809@huawei.com> | 2022-09-14 11:37:55 +0800 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2022-09-29 17:54:29 -0700 |
| commit | 6a02124c87f0b61dcaaeb65e7fd406d8afb40fd4 (patch) | |
| tree | d8820bef499644eb9dc0594d02b71023919df64d /drivers/dax | |
| parent | 0f702033a64bd3adcd57c9d5cf91ea64c08fad42 (diff) | |
| download | lwn-6a02124c87f0b61dcaaeb65e7fd406d8afb40fd4.tar.gz lwn-6a02124c87f0b61dcaaeb65e7fd406d8afb40fd4.zip | |
ACPI: HMAT: Release platform device in case of platform_device_add_data() fails
The platform device is not released when platform_device_add_data()
fails. And platform_device_put() perfom one more pointer check than
put_device() to check for errors in the 'pdev' pointer.
Use platform_device_put() to release platform device in
platform_device_add()/platform_device_add_data()/
platform_device_add_resources() error case.
Fixes: c01044cc8191 ("ACPI: HMAT: refactor hmat_register_target_device to hmem_register_device")
Signed-off-by: Lin Yujun <linyujun809@huawei.com>
Link: https://lore.kernel.org/r/20220914033755.99924-1-linyujun809@huawei.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dax')
| -rw-r--r-- | drivers/dax/hmem/device.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dax/hmem/device.c b/drivers/dax/hmem/device.c index cb6401c9e9a4..f87ae005431a 100644 --- a/drivers/dax/hmem/device.c +++ b/drivers/dax/hmem/device.c @@ -47,7 +47,7 @@ void hmem_register_device(int target_nid, struct resource *r) rc = platform_device_add_data(pdev, &info, sizeof(info)); if (rc < 0) { pr_err("hmem memregion_info allocation failure for %pr\n", &res); - goto out_pdev; + goto out_resource; } rc = platform_device_add_resources(pdev, &res, 1); @@ -65,7 +65,7 @@ void hmem_register_device(int target_nid, struct resource *r) return; out_resource: - put_device(&pdev->dev); + platform_device_put(pdev); out_pdev: memregion_free(id); } |