diff options
| author | Tom Rix <trix@redhat.com> | 2021-12-22 09:29:23 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2021-12-31 18:10:56 +1100 |
| commit | c5d692a2335d64ac390aeb8ab6c4ac9f662e1be4 (patch) | |
| tree | 91952b302d5b7989fe118b1da7a91610c525b3d7 /drivers/crypto | |
| parent | 304b4acee2f023a67f122d15a37b40ce460244d9 (diff) | |
| download | lwn-c5d692a2335d64ac390aeb8ab6c4ac9f662e1be4.tar.gz lwn-c5d692a2335d64ac390aeb8ab6c4ac9f662e1be4.zip | |
crypto: hisilicon - cleanup warning in qm_get_qos_value()
Building with clang static analysis returns this warning:
qm.c:4382:11: warning: The left operand of '==' is a garbage value
if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
~~~~ ^
The call to qm_qos_value_init() can return an error without setting
*val. So check ret before checking *val.
Fixes: 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/hisilicon/qm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index b731cb4ec294..c5b84a5ea350 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -4394,7 +4394,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf, return -EINVAL; ret = qm_qos_value_init(val_buf, val); - if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) { + if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) { pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n"); return -EINVAL; } |