diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> | 2024-08-26 08:58:01 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2024-08-28 11:54:22 -0700 |
| commit | f92d67e23b8caa81f6322a2bad1d633b00ca000e (patch) | |
| tree | 372c064d1361f77799a470daa6e785d3afe88433 /drivers/clk | |
| parent | f7e41b65bdc570335dec68d5f65f6317c3eaeeac (diff) | |
| download | lwn-f92d67e23b8caa81f6322a2bad1d633b00ca000e.tar.gz lwn-f92d67e23b8caa81f6322a2bad1d633b00ca000e.zip | |
clk: bcm: bcm53573: fix OF node leak in init
Driver code is leaking OF node reference from of_get_parent() in
bcm53573_ilp_init(). Usage of of_get_parent() is not needed in the
first place, because the parent node will not be freed while we are
processing given node (triggered by CLK_OF_DECLARE()). Thus fix the
leak by accessing parent directly, instead of of_get_parent().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826065801.17081-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk')
| -rw-r--r-- | drivers/clk/bcm/clk-bcm53573-ilp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/bcm/clk-bcm53573-ilp.c b/drivers/clk/bcm/clk-bcm53573-ilp.c index 84f2af736ee8..83ef41d618be 100644 --- a/drivers/clk/bcm/clk-bcm53573-ilp.c +++ b/drivers/clk/bcm/clk-bcm53573-ilp.c @@ -112,7 +112,7 @@ static void bcm53573_ilp_init(struct device_node *np) goto err_free_ilp; } - ilp->regmap = syscon_node_to_regmap(of_get_parent(np)); + ilp->regmap = syscon_node_to_regmap(np->parent); if (IS_ERR(ilp->regmap)) { err = PTR_ERR(ilp->regmap); goto err_free_ilp; |