diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-03-04 00:07:57 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-03-04 00:11:52 -0800 |
| commit | 948731115774c2e5ff7409360f35389459502211 (patch) | |
| tree | 7a6c8901195861939ac7f9bde508d62f7403bb0d /drivers/block | |
| parent | b9bdcd9bd78d253dcc8e13c29f0acd67e080e7c1 (diff) | |
| download | lwn-948731115774c2e5ff7409360f35389459502211.tar.gz lwn-948731115774c2e5ff7409360f35389459502211.zip | |
aoe: error printed 1 too early
with while (i-- > 0); i reaches -1 after the loop, so the test below is printed
one too early: 0 still means success.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/aoe/aoedev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index cc250577d405..eeea477d9601 100644 --- a/drivers/block/aoe/aoedev.c +++ b/drivers/block/aoe/aoedev.c @@ -173,7 +173,7 @@ skbfree(struct sk_buff *skb) return; while (atomic_read(&skb_shinfo(skb)->dataref) != 1 && i-- > 0) msleep(Sms); - if (i <= 0) { + if (i < 0) { printk(KERN_ERR "aoe: %s holds ref: %s\n", skb->dev ? skb->dev->name : "netif", |