diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2020-11-16 17:21:14 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2020-11-18 16:42:07 -0800 |
| commit | 6dceaa9f56e22d0f9b4c4ad2ed9e04e315ce7fe5 (patch) | |
| tree | 64bcf02a80ddf3c915c55c92af4cd3b8f374c052 /drivers/atm | |
| parent | d8c19014bba8f565d8a2f1f46b4e38d1d97bf1a7 (diff) | |
| download | lwn-6dceaa9f56e22d0f9b4c4ad2ed9e04e315ce7fe5.tar.gz lwn-6dceaa9f56e22d0f9b4c4ad2ed9e04e315ce7fe5.zip | |
atm: nicstar: Unmap DMA on send error
The `skb' is mapped for DMA in ns_send() but does not unmap DMA in case
push_scqe() fails to submit the `skb'. The memory of the `skb' is
released so only the DMA mapping is leaking.
Unmap the DMA mapping in case push_scqe() failed.
Fixes: 864a3ff635fa7 ("atm: [nicstar] remove virt_to_bus() and support 64-bit platforms")
Cc: Chas Williams <3chas3@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/atm')
| -rw-r--r-- | drivers/atm/nicstar.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 7af74fb450a0..09ad73361879 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -1706,6 +1706,8 @@ static int ns_send(struct atm_vcc *vcc, struct sk_buff *skb) if (push_scqe(card, vc, scq, &scqe, skb) != 0) { atomic_inc(&vcc->stats->tx_err); + dma_unmap_single(&card->pcidev->dev, NS_PRV_DMA(skb), skb->len, + DMA_TO_DEVICE); dev_kfree_skb_any(skb); return -EIO; } |