diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2018-09-11 14:43:38 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-09-11 16:56:46 -0600 |
| commit | ce42c1768152277658d48196f144aa406a4ea52a (patch) | |
| tree | 012c82e6a62c6cc76cac01f89eb25d305b71f676 /drivers/ata/pata_atiixp.c | |
| parent | 20bdc376b427cb420836f39ee8f281ea85dbaeef (diff) | |
| download | lwn-ce42c1768152277658d48196f144aa406a4ea52a.tar.gz lwn-ce42c1768152277658d48196f144aa406a4ea52a.zip | |
pata_atiixp: Remove unnecessary parentheses
Clang warns when more than one set of parentheses is used for a
single conditional statement:
drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
around the comparison to silence this warning
if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
~ ^ ~
drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
comparison into an assignment
if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
^~
=
1 warning generated.
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/ata/pata_atiixp.c')
| -rw-r--r-- | drivers/ata/pata_atiixp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c index 4d49fd3c927b..843bb200a1ee 100644 --- a/drivers/ata/pata_atiixp.c +++ b/drivers/ata/pata_atiixp.c @@ -279,7 +279,7 @@ static int atiixp_init_one(struct pci_dev *pdev, const struct pci_device_id *id) const struct ata_port_info *ppi[] = { &info, &info }; /* SB600 doesn't have secondary port wired */ - if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)) + if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE) ppi[1] = &ata_dummy_port_info; return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL, |