diff options
| author | Jean Delvare <jdelvare@suse.de> | 2016-01-18 17:06:05 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2016-01-19 15:52:10 +0800 |
| commit | fd7f6727102a1ccf6b4c1dfcc631f9b546526b26 (patch) | |
| tree | 96e33af1bc3caf9690fee29ed3331a88a90272c5 /crypto | |
| parent | 4f0414e54e4d1893c6f08260693f8ef84c929293 (diff) | |
| download | lwn-fd7f6727102a1ccf6b4c1dfcc631f9b546526b26.tar.gz lwn-fd7f6727102a1ccf6b4c1dfcc631f9b546526b26.zip | |
crypto: crc32c - Fix crc32c soft dependency
I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.
OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)
Cc: stable@vger.kernel.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/crc32c_generic.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/crypto/crc32c_generic.c b/crypto/crc32c_generic.c index 06f1b60f02b2..4c0a0e271876 100644 --- a/crypto/crc32c_generic.c +++ b/crypto/crc32c_generic.c @@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations wrapper for lib/crc32c"); MODULE_LICENSE("GPL"); MODULE_ALIAS_CRYPTO("crc32c"); MODULE_ALIAS_CRYPTO("crc32c-generic"); -MODULE_SOFTDEP("pre: crc32c"); |