summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorCaleb Sander Mateos <csander@purestorage.com>2024-08-15 11:15:40 -0600
committerThomas Gleixner <tglx@linutronix.de>2024-08-20 17:13:40 +0200
commite68ac2b488495fa4d127d6105ce633849859957a (patch)
treee51967f78ada2e341c3c5f057ea757fd671724d2 /block
parent24d02c4e53e2f02da16b2ae8a1bc92553110ca25 (diff)
downloadlwn-e68ac2b488495fa4d127d6105ce633849859957a.tar.gz
lwn-e68ac2b488495fa4d127d6105ce633849859957a.zip
softirq: Remove unused 'action' parameter from action callback
When soft interrupt actions are called, they are passed a pointer to the struct softirq action which contains the action's function pointer. This pointer isn't useful, as the action callback already knows what function it is. And since each callback handles a specific soft interrupt, the callback also knows which soft interrupt number is running. No soft interrupt action callback actually uses this parameter, so remove it from the function pointer signature. This clarifies that soft interrupt actions are global routines and makes it slightly cheaper to call them. Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Jens Axboe <axboe@kernel.dk> Link: https://lore.kernel.org/all/20240815171549.3260003-1-csander@purestorage.com
Diffstat (limited to 'block')
-rw-r--r--block/blk-mq.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c
index e3c3c0c21b55..aa28157b1aaf 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1128,7 +1128,7 @@ static void blk_complete_reqs(struct llist_head *list)
rq->q->mq_ops->complete(rq);
}
-static __latent_entropy void blk_done_softirq(struct softirq_action *h)
+static __latent_entropy void blk_done_softirq(void)
{
blk_complete_reqs(this_cpu_ptr(&blk_cpu_done));
}