diff options
| author | Sean Christopherson <seanjc@google.com> | 2023-11-03 16:05:39 -0700 |
|---|---|---|
| committer | Sean Christopherson <seanjc@google.com> | 2023-11-30 12:52:54 -0800 |
| commit | ec61b2306dfd117ba5db93dfb54808523ea2b5e0 (patch) | |
| tree | 4adf7ac6ae5b7bdf44af37999e608ff0f7c9246e /arch/x86/kvm/pmu.c | |
| parent | f2f63f7ec6fd13d2d5d5c6d90ea438fbb5a36adc (diff) | |
| download | lwn-ec61b2306dfd117ba5db93dfb54808523ea2b5e0.tar.gz lwn-ec61b2306dfd117ba5db93dfb54808523ea2b5e0.zip | |
KVM: x86/pmu: Remove manual clearing of fields in kvm_pmu_init()
Remove code that unnecessarily clears event_count and need_cleanup in
kvm_pmu_init(), the entire kvm_pmu is zeroed just a few lines earlier.
Vendor code doesn't set event_count or need_cleanup during .init(), and
if either VMX or SVM did set those fields it would be a flagrant bug.
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Link: https://lore.kernel.org/r/20231103230541.352265-5-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86/kvm/pmu.c')
| -rw-r--r-- | arch/x86/kvm/pmu.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c index 458e836c6efe..c06090196b00 100644 --- a/arch/x86/kvm/pmu.c +++ b/arch/x86/kvm/pmu.c @@ -710,8 +710,6 @@ void kvm_pmu_init(struct kvm_vcpu *vcpu) memset(pmu, 0, sizeof(*pmu)); static_call(kvm_x86_pmu_init)(vcpu); - pmu->event_count = 0; - pmu->need_cleanup = false; kvm_pmu_refresh(vcpu); } |