summaryrefslogtreecommitdiff
path: root/arch/x86/boot/startup
diff options
context:
space:
mode:
authorArd Biesheuvel <ardb@kernel.org>2025-05-04 11:52:31 +0200
committerIngo Molnar <mingo@kernel.org>2025-05-04 15:27:23 +0200
commitbd4a58beaaf1f4aff025282c6e8b130bdb4a29e4 (patch)
treea4f11fb7079f7b602cd7c75a058cdab452c130ad /arch/x86/boot/startup
parent39ffd86dd7f9b418847c17fa5dee6273e5ec5759 (diff)
downloadlwn-bd4a58beaaf1f4aff025282c6e8b130bdb4a29e4.tar.gz
lwn-bd4a58beaaf1f4aff025282c6e8b130bdb4a29e4.zip
x86/boot: Move early_setup_gdt() back into head64.c
Move early_setup_gdt() out of the startup code that is callable from the 1:1 mapping - this is not needed, and instead, it is better to expose the helper that does reside in __head directly. This reduces the amount of code that needs special checks for 1:1 execution suitability. In particular, it avoids dealing with the GHCB page (and its physical address) in startup code, which runs from the 1:1 mapping, making physical to virtual translations ambiguous. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: David Woodhouse <dwmw@amazon.co.uk> Cc: Dionna Amalie Glaze <dionnaglaze@google.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Kees Cook <keescook@chromium.org> Cc: Kevin Loughlin <kevinloughlin@google.com> Cc: Len Brown <len.brown@intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Cc: Tom Lendacky <thomas.lendacky@amd.com> Cc: linux-efi@vger.kernel.org Link: https://lore.kernel.org/r/20250504095230.2932860-26-ardb+git@google.com
Diffstat (limited to 'arch/x86/boot/startup')
-rw-r--r--arch/x86/boot/startup/gdt_idt.c15
1 files changed, 1 insertions, 14 deletions
diff --git a/arch/x86/boot/startup/gdt_idt.c b/arch/x86/boot/startup/gdt_idt.c
index 7e34d0b426b1..a3112a69b06a 100644
--- a/arch/x86/boot/startup/gdt_idt.c
+++ b/arch/x86/boot/startup/gdt_idt.c
@@ -24,7 +24,7 @@
static gate_desc bringup_idt_table[NUM_EXCEPTION_VECTORS] __page_aligned_data;
/* This may run while still in the direct mapping */
-static void __head startup_64_load_idt(void *vc_handler)
+void __head startup_64_load_idt(void *vc_handler)
{
struct desc_ptr desc = {
.address = (unsigned long)rip_rel_ptr(bringup_idt_table),
@@ -43,19 +43,6 @@ static void __head startup_64_load_idt(void *vc_handler)
native_load_idt(&desc);
}
-/* This is used when running on kernel addresses */
-void early_setup_idt(void)
-{
- void *handler = NULL;
-
- if (IS_ENABLED(CONFIG_AMD_MEM_ENCRYPT)) {
- setup_ghcb();
- handler = vc_boot_ghcb;
- }
-
- startup_64_load_idt(handler);
-}
-
/*
* Setup boot CPU state needed before kernel switches to virtual addresses.
*/