summaryrefslogtreecommitdiff
path: root/arch/powerpc
diff options
context:
space:
mode:
authorChristophe Leroy <christophe.leroy@c-s.fr>2019-05-06 08:10:43 +0000
committerMichael Ellerman <mpe@ellerman.id.au>2019-05-06 20:21:56 +1000
commit67d53f30e23ec66aa7bbdd1592d5e64d46876190 (patch)
tree1b430a93eb1bd77412da53d36e98f00f76c3bb1f /arch/powerpc
parentc4e31847a5490d52ddd44440a524e8355be11ec1 (diff)
downloadlwn-67d53f30e23ec66aa7bbdd1592d5e64d46876190.tar.gz
lwn-67d53f30e23ec66aa7bbdd1592d5e64d46876190.zip
powerpc/mm: fix section mismatch for setup_kup()
commit b28c97505eb1 ("powerpc/64: Setup KUP on secondary CPUs") moved setup_kup() out of the __init section. As stated in that commit, "this is only for 64-bit". But this function is also used on PPC32, where the two functions called by setup_kup() are in the __init section, so setup_kup() has to either be kept in the __init section on PPC32 or marked __ref. This patch marks it __ref, it fixes the below build warnings. MODPOST vmlinux.o WARNING: vmlinux.o(.text+0x169ec): Section mismatch in reference from the function setup_kup() to the function .init.text:setup_kuep() The function setup_kup() references the function __init setup_kuep(). This is often because setup_kup lacks a __init annotation or the annotation of setup_kuep is wrong. WARNING: vmlinux.o(.text+0x16a04): Section mismatch in reference from the function setup_kup() to the function .init.text:setup_kuap() The function setup_kup() references the function __init setup_kuap(). This is often because setup_kup lacks a __init annotation or the annotation of setup_kuap is wrong. Fixes: b28c97505eb1 ("powerpc/64: Setup KUP on secondary CPUs") Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc')
-rw-r--r--arch/powerpc/mm/init-common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c
index 6ea5607fc564..3bcae9e5e954 100644
--- a/arch/powerpc/mm/init-common.c
+++ b/arch/powerpc/mm/init-common.c
@@ -45,7 +45,7 @@ static int __init parse_nosmap(char *p)
}
early_param("nosmap", parse_nosmap);
-void setup_kup(void)
+void __ref setup_kup(void)
{
setup_kuep(disable_kuep);
setup_kuap(disable_kuap);