summaryrefslogtreecommitdiff
path: root/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
diff options
context:
space:
mode:
authorJohan Jonker <jbx6244@gmail.com>2020-04-28 16:49:33 +0200
committerHeiko Stuebner <heiko@sntech.de>2020-05-19 00:15:56 +0200
commite916d85b922fed7be861f63e388214bba6f20719 (patch)
tree9154bac4937947506a9a0969d6f78f5999d5ee15 /arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
parent84836ded76ec9a6f25d1d0acebaad44977e0ec6f (diff)
downloadlwn-e916d85b922fed7be861f63e388214bba6f20719.tar.gz
lwn-e916d85b922fed7be861f63e388214bba6f20719.zip
arm64: dts: rockchip: rename and label gpio-led subnodes
Current dts files with 'gpio-led' nodes were manually verified. In order to automate this process leds-gpio.txt has been converted to yaml. With this conversion a check for pattern properties was added. A test with the command below gives a screen full of warnings like: arch/arm64/boot/dts/rockchip/rk3368-r88.dt.yaml: gpio-leds: 'work' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Fix these errors with help of the following rules: 1: Add nodename in the preferred form. 2: Always add a label that ends with '_led' to prevent conflicts with other labels such as 'power' and 'mmc' 3: If leds need pinctrl add a label that ends with '_led_pin' also to prevent conflicts with other labels. patternProperties: # The first form is preferred, but fall back to just 'led' # anywhere in the node name to at least catch some child nodes. "(^led-[0-9a-f]$|led)": make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/ leds-gpio.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> Link: https://lore.kernel.org/r/20200428144933.10953-2-jbx6244@gmail.com Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Diffstat (limited to 'arch/arm64/boot/dts/rockchip/rk3328-rock64.dts')
-rw-r--r--arch/arm64/boot/dts/rockchip/rk3328-rock64.dts4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index bf3e546f5266..0e453784fa2d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -73,12 +73,12 @@
leds {
compatible = "gpio-leds";
- power {
+ power_led: led-0 {
gpios = <&rk805 1 GPIO_ACTIVE_LOW>;
linux,default-trigger = "mmc0";
};
- standby {
+ standby_led: led-1 {
gpios = <&rk805 0 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};