diff options
author | Simon Horman <horms@kernel.org> | 2024-08-06 12:28:24 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-07 20:21:05 -0700 |
commit | 91d516d4de48532d967a77967834e00c8c53dfe6 (patch) | |
tree | 6c3d601e7173012c9a800b167935046b58a8dba2 /arch/alpha/include/asm/irq.h | |
parent | 7d70ed9f9c6a9537379ff645d6befea4c203aa98 (diff) | |
download | lwn-91d516d4de48532d967a77967834e00c8c53dfe6.tar.gz lwn-91d516d4de48532d967a77967834e00c8c53dfe6.zip |
net: mvpp2: Increase size of queue_name buffer
Increase size of queue_name buffer from 30 to 31 to accommodate
the largest string written to it. This avoids truncation in
the possibly unlikely case where the string is name is the
maximum size.
Flagged by gcc-14:
.../mvpp2_main.c: In function 'mvpp2_probe':
.../mvpp2_main.c:7636:32: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=]
7636 | "stats-wq-%s%s", netdev_name(priv->port_list[0]->dev),
| ^
.../mvpp2_main.c:7635:9: note: 'snprintf' output between 10 and 31 bytes into a destination of size 30
7635 | snprintf(priv->queue_name, sizeof(priv->queue_name),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
7636 | "stats-wq-%s%s", netdev_name(priv->port_list[0]->dev),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
7637 | priv->port_count > 1 ? "+" : "");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics").
I am not flagging this as a bug as I am not aware that it is one.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Link: https://patch.msgid.link/20240806-mvpp2-namelen-v1-1-6dc773653f2f@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'arch/alpha/include/asm/irq.h')
0 files changed, 0 insertions, 0 deletions