diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2024-08-29 19:50:32 +0300 |
---|---|---|
committer | Hans de Goede <hdegoede@redhat.com> | 2024-09-04 20:17:31 +0200 |
commit | a093cb667c3ff5eadd4b23ddf996d9ccae9b7ac6 (patch) | |
tree | 7dbff4de9dac50ab27ca37ffd0738c96d16f4d0d /Kbuild | |
parent | 24b6616355f7eb2a839776578b104a0348b4f77f (diff) | |
download | lwn-a093cb667c3ff5eadd4b23ddf996d9ccae9b7ac6.tar.gz lwn-a093cb667c3ff5eadd4b23ddf996d9ccae9b7ac6.zip |
platform/x86: ideapad-laptop: Make the scope_guard() clear of its scope
First of all, it's a bit counterintuitive to have something like
int err;
...
scoped_guard(...)
err = foo(...);
if (err)
return err;
Second, with a particular kernel configuration and compiler version in
one of such cases the objtool is not happy:
ideapad-laptop.o: warning: objtool: .text.fan_mode_show: unexpected end of section
I'm not an expert on all this, but the theory is that compiler and
linker in this case can't understand that 'result' variable will be
always initialized as long as no error has been returned. Assigning
'result' to a dummy value helps with this. Note, that fixing the
scoped_guard() scope (as per above) does not make issue gone.
That said, assign dummy value and make the scope_guard() clear of its scope.
For the sake of consistency do it in the entire file.
Fixes: 7cc06e729460 ("platform/x86: ideapad-laptop: add a mutex to synchronize VPC commands")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202408290219.BrPO8twi-lkp@intel.com/
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240829165105.1609180-1-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions