diff options
| author | Rob Herring (Arm) <robh@kernel.org> | 2026-06-12 16:53:32 -0500 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-06-13 05:53:18 -0700 |
| commit | 9955c92abe72564a49c293b1c15cd3b4f02ea6a0 (patch) | |
| tree | 4f7a5227f261a7bbd27d669f520df6c661a0af61 | |
| parent | 83dda7ed185501ba1f8165aeca83ff4a8ef7c263 (diff) | |
| download | lwn-9955c92abe72564a49c293b1c15cd3b4f02ea6a0.tar.gz lwn-9955c92abe72564a49c293b1c15cd3b4f02ea6a0.zip | |
hwmon: tmp401: Read "ti,n-factor" as signed
The "ti,n-factor" binding and examples allow negative correction
values. Reading it as u32 makes the helper type disagree with the
documented signed value and hides real schema mismatches.
Use the signed helper so the DT access matches the s32 value stored by
the driver.
Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20260612215332.1889497-1-robh@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/tmp401.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c index a09225a87355..ca0ff525ea29 100644 --- a/drivers/hwmon/tmp401.c +++ b/drivers/hwmon/tmp401.c @@ -560,7 +560,7 @@ static int tmp401_init_client(struct tmp401_data *data) return ret; } - ret = of_property_read_u32(data->client->dev.of_node, "ti,n-factor", &nfactor); + ret = of_property_read_s32(data->client->dev.of_node, "ti,n-factor", &nfactor); if (!ret) { if (data->kind == tmp401) { dev_err(&data->client->dev, "ti,tmp401 does not support n-factor correction\n"); |