diff options
| author | Steve French <stfrench@microsoft.com> | 2023-04-26 22:01:31 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-04-28 21:23:42 -0500 |
| commit | 943fb67b090212f1d3789eb7796b1c9045c62fd6 (patch) | |
| tree | f4c7a6051a4238cf12fe3dc1abdf9971ecb2c9c5 | |
| parent | d906be3fa571f6fc9381911304a0eca99f1b6951 (diff) | |
| download | lwn-943fb67b090212f1d3789eb7796b1c9045c62fd6.tar.gz lwn-943fb67b090212f1d3789eb7796b1c9045c62fd6.zip | |
cifs: missing lock when updating session status
Coverity noted a place where we were not grabbing
the ses_lock when setting (and checking) ses_status.
Addresses-Coverity: 1536833 ("Data race condition (MISSING_LOCK)")
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: Bharath SM <bharathsm@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/connect.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 1cbb90587995..7bfef741f758 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -1916,18 +1916,22 @@ void cifs_put_smb_ses(struct cifs_ses *ses) /* ses_count can never go negative */ WARN_ON(ses->ses_count < 0); + spin_lock(&ses->ses_lock); if (ses->ses_status == SES_GOOD) ses->ses_status = SES_EXITING; - cifs_free_ipc(ses); - if (ses->ses_status == SES_EXITING && server->ops->logoff) { + spin_unlock(&ses->ses_lock); + cifs_free_ipc(ses); xid = get_xid(); rc = server->ops->logoff(xid, ses); if (rc) cifs_server_dbg(VFS, "%s: Session Logoff failure rc=%d\n", __func__, rc); _free_xid(xid); + } else { + spin_unlock(&ses->ses_lock); + cifs_free_ipc(ses); } spin_lock(&cifs_tcp_ses_lock); |