diff options
| author | Michel Dänzer <michel.daenzer@amd.com> | 2018-05-01 15:24:11 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2018-05-02 14:48:55 +0200 |
| commit | 892a0be43edd63e1cd228af3453a064e9e94f08e (patch) | |
| tree | 16c2eccb0973ca293540b70f25a49059d5b872d4 | |
| parent | 2d618bdf71635463a4aa4ad0fe46ec852292bc0c (diff) | |
| download | lwn-892a0be43edd63e1cd228af3453a064e9e94f08e.tar.gz lwn-892a0be43edd63e1cd228af3453a064e9e94f08e.zip | |
swiotlb: fix inversed DMA_ATTR_NO_WARN test
The result was printing the warning only when we were explicitly asked
not to.
Cc: stable@vger.kernel.org
Fixes: 0176adb004065d6815a8e67946752df4cd947c5b "swiotlb: refactor
coherent buffer allocation"
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
Signed-off-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | lib/swiotlb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/swiotlb.c b/lib/swiotlb.c index fece57566d45..12fbaa445637 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -737,7 +737,7 @@ out_unmap: swiotlb_tbl_unmap_single(dev, phys_addr, size, DMA_TO_DEVICE, DMA_ATTR_SKIP_CPU_SYNC); out_warn: - if ((attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) { + if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) { dev_warn(dev, "swiotlb: coherent allocation failed, size=%zu\n", size); |